search

JuliaGaussianProcesses / Stheno.jl

Probabilistic Programming with Gaussian processes in Julia
Other
339 stars 26 forks source link

Upgrade ZygoteRules to ChainRules #193

Closed willtebbutt closed 3 years ago

willtebbutt commented 3 years ago

There are some rules in Zygote.jl which are still getting in the way of ChainRules rules in Stheno.jl. These need to be removed before I can properly upgrade to ChainRules rules.

Rules that need to be moved from Zygote to ChainRules:

edit: this PR upgrades some of the rules, not all of them though.

codecov-commenter commented 3 years ago

Codecov Report

Merging #193 (db3edcd) into master (be39287) will increase coverage by 0.29%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   85.45%   85.74%   +0.29%     
==========================================
  Files          17       17              
  Lines         440      442       +2     
==========================================
+ Hits          376      379       +3     
+ Misses         64       63       -1
Impacted Files Coverage Δ
src/composite/compose.jl 68.18% <0.00%> (ø)
src/util/zygote_rules.jl 100.00% <ø> (ø)
src/util/block_arrays/dense.jl 94.11% <90.00%> (+7.45%) :arrow_up:
src/composite/cross.jl 97.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be39287...db3edcd. Read the comment docs.