Closed RalphAS closed 1 year ago
I hope someone more familiar with the package can update the tests appropriately.
Thanks for opening this @RalphAS . Would you mind providing a MWE that shows how you wound up in this situation? It will be easier to figure out how to test this given that information.
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
2023b63
) compared to base (bd15654
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I put a small example in the issue (238). I don't know the internals well enough to reduce it further with confidence, but I surmise that logpdf
handles the covariance with the UpperTriangular
U
property of a Cholesky
object.
Sorry for taking ages to look at this.
I think this basically fixes the problem, but it would be great if you could replace this block of tests with something like this:
@timedtestset "BlockMatrix" begin
@timedtestset "Array cotangent" begin
Ps = [3, 4, 5]
Qs = [6, 7, 8, 9]
X = BlockArray(randn(sum(Ps), sum(Qs)), Ps, Qs).blocks
Ȳ = randn(sum(Ps), sum(Qs))
adjoint_test(Stheno._collect ∘ Stheno._mortar, Ȳ, X)
end
@timedtestset "UpperTriangular cotangent" begin
Ps = [3, 4, 5]
X = BlockArray(randn(sum(Ps), sum(Ps)), Ps, Ps).blocks
Ȳ = UpperTriangular(randn(sum(Ps), sum(Ps)))
adjoint_test(Stheno._collect ∘ Stheno._mortar, Ȳ, X)
end
end
so that we have a test that fails under the current implementation.
Closed by #243
This change fixes #238 by matching the signature of the standard BlockArray constructor.