JuliaGaussianProcesses / Stheno.jl

Probabilistic Programming with Gaussian processes in Julia
Other
338 stars 26 forks source link

Fix AD #244

Closed willtebbutt closed 1 year ago

willtebbutt commented 1 year ago

@martincornejo apologies for the delay on this. You were right about the mean_vector stuff, but it turns out we just need to opt out of some rrules in order to get this stuff to work.

Do you mind if we go with this approach rather than yours?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bd15654) 100.00% compared to head (7f28e95) 100.00%.

:exclamation: Current head 7f28e95 differs from pull request most recent head 4083ed0. Consider uploading reports for the commit 4083ed0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #244 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 12 +1 Lines 285 287 +2 ========================================= + Hits 285 287 +2 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses) | Coverage Δ | | |---|---|---| | [src/Stheno.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL1N0aGVuby5qbA==) | `100.00% <ø> (ø)` | | | [src/affine\_transformations/addition.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2FmZmluZV90cmFuc2Zvcm1hdGlvbnMvYWRkaXRpb24uamw=) | `100.00% <ø> (ø)` | | | [src/affine\_transformations/compose.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2FmZmluZV90cmFuc2Zvcm1hdGlvbnMvY29tcG9zZS5qbA==) | `100.00% <ø> (ø)` | | | [src/affine\_transformations/cross.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2FmZmluZV90cmFuc2Zvcm1hdGlvbnMvY3Jvc3Muamw=) | `100.00% <ø> (ø)` | | | [src/gp/atomic\_gp.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2dwL2F0b21pY19ncC5qbA==) | `100.00% <ø> (ø)` | | | [src/gp/derived\_gp.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2dwL2Rlcml2ZWRfZ3Auamw=) | `100.00% <ø> (ø)` | | | [src/affine\_transformations/product.jl](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2FmZmluZV90cmFuc2Zvcm1hdGlvbnMvcHJvZHVjdC5qbA==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaGaussianProcesses/Stheno.jl/pull/244/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

martincornejo commented 1 year ago

Perfect! I've been working with my fix in the meanwhile, but this solution is much better. Thanks!