search

JuliaGeo / GADM.jl

A Julia package for obtaining geographical data from the GADM dataset
https://gadm.org
MIT License
38 stars 4 forks source link

Add GADM_ prefix to downloaded folders #28

Closed visr closed 3 years ago

visr commented 3 years ago

Quite a minor point, but I noticed that the country codes are directly placed under the datadeps folder:

c:\Users\visser_mn\.julia\datadeps\IND\
c:\Users\visser_mn\.julia\datadeps\VAT\

Perhaps it would be better to keep them together under a GADM directory, such that if we want we can more easily delete them, because they won't be mixed with other DataDeps data?

c:\Users\visser_mn\.julia\datadeps\GADM\IND\
c:\Users\visser_mn\.julia\datadeps\GADM\VAT\
zerefwayne commented 3 years ago

It is not possible to store them in a separate directory. What do you think of storing them as GADM_IND instead?

On Wed, 11 Nov 2020, 02:05 Martijn Visser, notifications@github.com wrote:

Quite a minor point, but I noticed that the country codes are directly placed under the datadeps folder:

c:\Users\visser_mn.julia\datadeps\IND\ c:\Users\visser_mn.julia\datadeps\VAT\

Perhaps it would be better to keep them together under a GADM directory, such that if we want we can more easily delete them, because they won't be mixed with other DataDeps data?

c:\Users\visser_mn.julia\datadeps\GADM\IND\ c:\Users\visser_mn.julia\datadeps\GADM\VAT\

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JuliaGeo/GADM.jl/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFPGKXGNK3VBVMADJEDSPGPZJANCNFSM4TREEAOA .

juliohm commented 3 years ago

@zerefwayne are you sure that DataDeps.jl doesn't allow customizing a root folder for the downloads?

zerefwayne commented 3 years ago

I went through the codebase and documentation but was unable to find anything related to it.

On Wed, 11 Nov 2020, 02:18 Júlio Hoffimann, notifications@github.com wrote:

@zerefwayne https://github.com/zerefwayne are you sure that DataDeps.jl doesn't allow customizing a root folder for the downloads?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaGeo/GADM.jl/issues/28#issuecomment-724957630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFMORRHM2CH22WSAJTDSPGRKTANCNFSM4TREEAOA .

juliohm commented 3 years ago

In this case, I think we need a separate PR to re-add the GADM_ prefix you had originall. Let's handle it after you finish the other PRs.

juliohm commented 3 years ago

If DataDeps.jl already handles conflicts of existing folders, we don't even need to think about adding the prefix though. It doesn't solve the issue that @visr pointed out though. Ideally we would be able to put every country on a common root folder.

visr commented 3 years ago

Yeah I tried looking into it a bit as well, but it seems there is no good way of putting it together, without downloading all countries. The GADM_ prefix is a good suggestion.