search

JuliaGeo / GADM.jl

A Julia package for obtaining geographical data from the GADM dataset
https://gadm.org
MIT License
38 stars 4 forks source link

Remove ArchGDAL.Table #39

Closed zerefwayne closed 3 years ago

zerefwayne commented 3 years ago

For reasons unknown to me, we can no more access the field inside the row by the symbol.

To go around this, I first find out the index of the field which contains the key and then get the field using getfield method.

@yeesian ArchGDAL.getfield(Feature, i) seems to be missing in the documentation.

I tried to run the code and it seems to work fine, please have another look @juliohm.

yeesian commented 3 years ago

Thanks for the ping! Yeah the implementation in this PR is correct for ArchGDAL v0.7, and the following test is failing:

https://github.com/JuliaGeo/GADM.jl/blob/f04d7c2d4c63ac9ffa14927b5f1404ae8f2a98c3/test/GADM.jl#L50

The tests will be more robust when they're testing for behavior rather than implementation, so I think it's better to remove that line/test altogether, since it might be subject to yet another change (pending the resolution of https://github.com/yeesian/ArchGDAL.jl/issues/223).

juliohm commented 3 years ago

@zerefwayne could you please remove that test as pointed out by @yeesian ?

juliohm commented 3 years ago

ping @zerefwayne

juliohm commented 3 years ago

Thank you @zerefwayne !