search

JuliaGeo / GeoJSON.jl

Utilities for working with GeoJSON data in Julia
https://juliageo.org/GeoJSON.jl/stable/
MIT License
68 stars 10 forks source link

Do not include fully qualified type info #13

Closed AndyGreenwell closed 8 years ago

AndyGreenwell commented 8 years ago

In order to create a valid GeoJSON file that can be used from Javascript libraries like d3, the GeoJSON objects included within the Dict created by geojson2dict (and hence included in the JSON objects themselves), cannot have the fully qualified Julia type information. Prior to this commit, when using Julia 0.4.5, the dictionaries created via geojson2dict for any GeoJSON object included the fully qualified type information, including the GeoJSON package name. This change ensures that only the geom entries in the tuple above are printed, but not the fully qualified type.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 90.526% when pulling 5990d922ba65dc13c9212f59b2bb09226c1e7a21 on AndyGreenwell:name-qualification-patch into cf69b8d3449e9cbe1f356f01356ae42ebf7dd375 on JuliaGeo:master.

yeesian commented 8 years ago

Thanks! While you're in there, can you help provide some tests for it as well?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 90.526% when pulling e4d752bfa440181e5951f430b82b005990a66a1c on AndyGreenwell:name-qualification-patch into cf69b8d3449e9cbe1f356f01356ae42ebf7dd375 on JuliaGeo:master.