Update for julia v0.5 - Githubissues

JuliaGeo / GeoJSON.jl

Utilities for working with GeoJSON data in Julia

https://juliageo.org/GeoJSON.jl/stable/

MIT License

68 stars 10 forks source link

Update for julia v0.5 #16

Closed yeesian closed 7 years ago

yeesian commented 7 years ago

use GeoInterface
drop support for julia0.4, and support julia0.5 onwards

yeesian commented 7 years ago

depends on https://github.com/JuliaGeo/GeoInterface.jl/pull/8

coveralls commented 7 years ago

Coverage decreased (-2.09%) to 88.333% when pulling 639643aed3b4a3a474ede86e87e303ea6ae32c6e on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 91.667% when pulling a38628afe2110a5a6acdfb13017381cc2f531995 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

coveralls commented 7 years ago

Coverage increased (+1.2%) to 91.667% when pulling a38628afe2110a5a6acdfb13017381cc2f531995 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

coveralls commented 7 years ago

Coverage increased (+2.8%) to 93.22% when pulling a38628afe2110a5a6acdfb13017381cc2f531995 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

coveralls commented 7 years ago

Coverage increased (+9.6%) to 100.0% when pulling b79fc3b1f1a64446fb8045ccc36d5881584a6870 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

coveralls commented 7 years ago

Coverage increased (+9.6%) to 100.0% when pulling b79fc3b1f1a64446fb8045ccc36d5881584a6870 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

yeesian commented 7 years ago

@visr no hurry; but this is now ready for review

visr commented 7 years ago

working on it

coveralls commented 7 years ago

Coverage increased (+2.8%) to 93.22% when pulling 67892d80a69f21e1b4b82ad40f2ef89740ffc0bb on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

visr commented 7 years ago

Nice, I have a commit pending that updates the readme.

yeesian commented 7 years ago

Sorry for adding one more change that came up as I was working on https://github.com/yeesian/LeafletJS.jl. Here are some samples: http://nbviewer.jupyter.org/github/yeesian/LeafletExamples.jl/blob/master/notebook/leaflet-providers.ipynb

Without the PR, there would be issues (e.g. with escaping string quotes) inside nested objects when using JSON.json(), and the API is now more consistent with naming conventions:

dict2geo() takes a Dict and converts it into a GeoInterface.* object
geo2dict() takes a GeoInterface.* object and converts it into a Dict
GeoJSON.geojson() returns a String (obeying the GeoJSON spec) similar to what JSON.json() might return.

I don't have any more pending changes to make, so feel free.

coveralls commented 7 years ago

Coverage increased (+1.1%) to 91.525% when pulling 009fc647f7328751e5c27c9cd75782fe1e7d4d55 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

coveralls commented 7 years ago

Coverage increased (+1.1%) to 91.525% when pulling 009fc647f7328751e5c27c9cd75782fe1e7d4d55 on julia0.5 into 63f85f5db1fb7ea78b6f664d00ed8b04d3064e67 on master.

visr commented 7 years ago

Added a few more commits. Go ahead and merge if you agree with those.

yeesian commented 7 years ago

Thanks!