search

JuliaGeo / GeoJSON.jl

Utilities for working with GeoJSON data in Julia
https://juliageo.org/GeoJSON.jl/stable/
MIT License
68 stars 10 forks source link

Bring GeoInterface concrete types over here #21

Closed visr closed 4 years ago

visr commented 4 years ago

The concrete types in GeoInterface.jl were written initially for this package and thus are a pretty good match. But if we want GeoInterface to support a wide selection of concrete types we probably need to move to an approach similar to Tables.jl, meaning we can take the concrete types out of GeoInterface.jl

Step one would be to move the types more or less as is. But possibly we directly switch the concrete types over to GeometryTypes, as suggested in https://github.com/JuliaGeo/GeoInterface.jl/issues/24?

yeesian commented 4 years ago

But possibly we directly switch the concrete types over to GeometryTypes, as suggested in JuliaGeo/GeoInterface.jl#24?

If it's possible, I'm on board with that

visr commented 4 years ago

Rather than using GeometryTypes it would probably make more sense to switch directly to GeometryBasics, see https://github.com/JuliaGeometry/GeometryTypes.jl/pull/166#issuecomment-518713253.

visr commented 4 years ago

I'll close this. Rather than taking this gradual step, it would probably be better to address this when we switch to the new GeoInterface being drafted in https://github.com/yeesian/GeoInterfaceRFC.jl.