Open ConnectedSystems opened 3 months ago
This is likely getting through tests because we test against OffsetArrays.jl and it pirates similar
https://github.com/JuliaArrays/OffsetArrays.jl/issues/306
I think I've fixed it for poligonize
in the testing PR that has taken forever to be merged.
But @jishnub this keeps happening. For the time being we will stop testing against OffsetArrays.jl, it's just not suitable to use in tests.
I'm unsure if I understand the issue here. OffsetArrays
defines similar
for AbstractUnitRange
axes, so a call with LinRange
as axes should fail anyway? Does this pass tests with OffsetArrays
loaded?
It's possible not with this exact range but we've had multiple problems and hacks around it already
I don't think this is an OffsetArrays issue in this particular case.
I think the issue is the code is the way it is to avoid another OffsetArrays.jl issue. There are a bunch of ways for similar to give you an OffsetArray when you don't want it
Trying out the example here: https://juliageo.org/GeometryOps.jl/stable/source/methods/polygonize#Polygonizing-raster-data
Results in an error