search

JuliaGeo / LibGEOS.jl

Julia package for manipulation and analysis of planar geometric objects
MIT License
72 stars 23 forks source link

Geointerface conversions #156

Closed rafaqz closed 1 year ago

rafaqz commented 1 year ago

This PR adds the new geointerface_geomtype local methods, updates convert to not use coordinates, and adds methods to all functions that will work on any compatible geometries.

There are some extra methods needed for some constructors to make convert more consistent.

Its not really practical to test this without wrapper types, the test objects are too limited:

So also waiting on https://github.com/JuliaGeo/GeoInterface.jl/pull/78

We may as well review this now as its basically ready to go, just needs 78 to work. @jw3126 if you would also like to review this that would be helpful.

rafaqz commented 1 year ago

This should be good to go. It's a breaking change because I have renamed Base.contains to LibGEOS.contains, otherwise we can't accept other geometries in it without piracy.

We can lump it with #155

I made this non breaking to reduce friction, there are now both Base.contains and LibGEOS.contains methods. We can remove the base method when we do #155

rafaqz commented 1 year ago

Bump

@visr @evetion @jw3126 can I get a review for this?

rafaqz commented 1 year ago

Yes I was thinking about adding a better internal getx etc method, but it can be separate.