search

JuliaGeo / LibGEOS.jl

Julia package for manipulation and analysis of planar geometric objects
MIT License
72 stars 24 forks source link

Refactor GeoInterface implementation. #161

Closed evetion closed 11 months ago

evetion commented 1 year ago

Should partially fix #160.

Made ngeom to be stable, was a Union{Int64, Int32} before. coordinates(multipolygon) can now be correctly inferred.

It's a bit ugly to define thing(AbstractPoint, NonPoint), but it's required for the ambiguity checks. Might be good to understand why this is required.

Similarly, redefining coordinates here for both all geometries and multigeometries makes it inferrable. Julia really doesn't seem to like type inference through recursion.

rafaqz commented 11 months ago

Would be good to merge this...

evetion commented 11 months ago

Thanks for the bump. Will try to address your comments later this week.

evetion commented 11 months ago

@rafaqz This should be good to go now.