search

JuliaGeo / Proj.jl

Julia wrapper for the PROJ cartographic projections library
MIT License
48 stars 9 forks source link

support only_best option #87

Open visr opened 1 year ago

visr commented 1 year ago

Edit: see post below about the only_best option that is new in PROJ 9.2.

PROJ 9.2.1 is already picked up by this package through PROJ_jll v900.200.100.

visr commented 1 year ago

The two remaining test failures can be fixed by enabling network access for those transformations. Otherwise we get these separate errors:

hgridshift: could not find required grid(s)
vgridshift: could not find required grid(s)

using Proj
Proj.enable_network!(false)
trans2 = Proj.Transformation("EPSG:32632", "EPSG:2027", always_xy = true) # fails, passed before, passes with network

I suspect this is related to the new ONLY_BEST option. This option looks like a great addition, but as I understand the PR it shouldn't break anything since it defaults to off. So I don't understand why it would affect our tests. This need some more investigation.

https://proj.org/en/9.2/news.html#id20 https://github.com/OSGeo/PROJ/pull/3535

Also perhaps we should add some support for the option just like pyproj:

https://github.com/pyproj4/pyproj/pull/1236

evetion commented 1 year ago

I don't mind this breaking change, it should be the default imho.