search

JuliaGeo / TileProviders.jl

Shared collection of map tile providers
MIT License
14 stars 5 forks source link

Fix handling of apikey keyword for services with variants #12

Closed mathieu17g closed 1 year ago

mathieu17g commented 1 year ago

I had an issue with GeoPortailFrance not taking in account the apikey keyword.

Now it works. I had to convert the options JSON3.object to Dict via copy

I added a test on the URL returned by geturl

rafaqz commented 1 year ago

Ok the question now is what to do about those Juilia 1.6 test failures.

mathieu17g commented 1 year ago

Ok the question now is what to do about those Juilia 1.6 test failures.

I do not have Linux, but macOS on Intel. I will run the tests locally with Julia 1.6 to see if I can reproduce the error

rafaqz commented 1 year ago

Maybe we used new syntax for replace that 1.6 doesnt have...

mathieu17g commented 1 year ago

Thanks, I’m following this lead. I have reviewed Julia 1.6.7 replace code, but have not found the root cause yet.

mathieu17g commented 1 year ago

Thanks, I’m following this lead. I have reviewed Julia 1.6.7 replace code, but have not found the root cause yet.

Well, no need to review the code, it was in docs. Support for multiple patterns requires version 1.7. I will adapt the code for VERSION < v"1.7"

mathieu17g commented 1 year ago

I guess I still have to raise the coverage a bit

mathieu17g commented 1 year ago

I guess I still have to raise the coverage a bit

Well, I can't see an easy way to enhance the coverage. @rafaqz, is it OK for you to leave it like this?

rafaqz commented 1 year ago

Perfect! no worries sbout coverage

Thanks for fixing the tests