Closed henrik-wolf closed 1 year ago
Thanks for all the fixes! There was a reason the NASAGIBBSTimeseries
was not included in the readme or the providers dict... (it was so buggy)
Do you want to be a maintainer here? This package was hacked together very quickly while we put together Tyler.jl. It could do with some more ongoing care, but I'm unlikely to find time for it.
@SuperGrobi might need to get out an old 1.6 version and see whats causing that failure. Probably one of the line you have added like the nada gibbs tests?
Something is wrong with replace
on line 89, although the method signature looks fine to me.
Sorry I just realised this was against my other PR that I totally forgot existed, and not master
I fixed a bunch of problems and inconsistencies I came across when playing around with different tile providers. Here they are: In the NASAGIBS file:
NASAGIBSTimeseries
failed due to the default keyword not being in the list of valid ones.NASAGIBSTimeseries
(still, somehow printing about 800 lines of variantlist makes the docstring basically useless in the REPL...)NASAGIBSTimeseries
toPROVIDER_DICT
in the providers file:
keyword
in the docstring to always be lowercase, since the keywords of the functions are as wellvariant
one line up, otherwise we get thekeyword
of theProvider
to show up as a possiblevariant
in the error messagemethods
function (see https://github.com/JuliaLang/julia/issues/49028)Tests:
Providers
in the order they appear in thejson
Readme:
PROVIDER_DICT