search

JuliaGeometry / Clipper.jl

Julia wrapping of clipper
Other
30 stars 17 forks source link

Interface with more functions from ClipperLib #42

Open plut opened 3 years ago

plut commented 3 years ago

(this is more a feature request than a true issue...)

Reading the documentation from ClipperLib, this library supports Minkowski sum and difference:

http://www.angusj.com/delphi/clipper/documentation/Docs/Units/ClipperLib/Functions/MinkowskiSum.htm

However these are not interfaced by Clipper.jl. I looked up a bit and neither are they present in libcclipper (this is not surprising). Since these two functions are quite useful, it would be nice to have them exported in Clipper.jl!

plut commented 2 years ago

So I have written some code that makes these two functions (Minkowski sum and difference) visible in the Clipper_jll.jl library. What is the procedure for submitting a PR on this topic? Should I send the PR directly to Yggdrasil (who will review it then)? How is it then propagated to Clipper_jll.jl (is there an auto-build?)

sjkelly commented 2 years ago

That sounds about right. A PR to Yggdrasil, once merged, will update the _jll. Please tag me in the Yggdrail PR so I can test locally before merge in Yggdrasil.