search

JuliaGeometry / Contour.jl

Calculating contour curves for 2D scalar fields in Julia
Other
44 stars 13 forks source link

Julia 0.4 compatibility #20

Closed dcjones closed 9 years ago

dcjones commented 9 years ago

Fixes #19 and recent errors on 0.4 from the tupocalypse.

I ran into #18 as well, but it turns out that it was fixed on ImmutableArrays master by https://github.com/JuliaGeometry/ImmutableArrays.jl/commit/e0e7bd958400461b5232f1569773ed3d205d6a8a.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-3.22%) to 93.33% when pulling 4412edb309339721d611854fc3267927c24831d3 on dcjones:compat into 2d5ca7de9d36da63b31e1eb7cab83a0b21d15dea on tlycken:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-3.22%) to 93.33% when pulling 79e5969669bf7b9813eaafbb006f4ac26356f674 on dcjones:compat into 2d5ca7de9d36da63b31e1eb7cab83a0b21d15dea on tlycken:master.

tomasaschan commented 9 years ago

I've only been able to test this on 0.4 on Windows, but with the latest master of ImmutableArrays.jl all tests pass. I've asked them to tag a new version, but in the meantime maybe you have tested it on 0.3? and since Travis tests passed on 0.3 I'll merge this as is; the package is broken on 0.4 anyway at the moment.

If using master on ImmutableArrays.jl doesn't solve the problems for you, please do file an issue.

tomasaschan commented 9 years ago

Thanks a lot for tackling this for me, btw! :+1: