search

JuliaGeometry / Contour.jl

Calculating contour curves for 2D scalar fields in Julia
Other
44 stars 13 forks source link

Broken on 0.4 master #21

Closed ViralBShah closed 9 years ago

ViralBShah commented 9 years ago

This is breaking Gadfly on 0.4 master as well right now.


LoadError: LoadError: LoadError: LoadError: ArgumentError: invalid type for argument pos in method definition for add_vertex! at /home/juser/.julia/v0.4/Contour/src/Contour.jl:146
while loading /home/juser/.julia/v0.4/Contour/src/Contour.jl, in expression starting on line 145
while loading /home/juser/.julia/v0.4/Gadfly/src/statistics.jl, in expression starting on line 5
while loading /home/juser/.julia/v0.4/Gadfly/src/Gadfly.jl, in expression starting on line 1054
while loading In[3], in expression starting on line 1

 in include at ./boot.jl:252
 in include_from_node1 at ./loading.jl:134
 in reload_path at ./loading.jl:158
 in _require at ./loading.jl:70
 in require at ./loading.jl:56
 in include at ./boot.jl:252
 in include_from_node1 at ./loading.jl:134
 in include at ./boot.jl:252
 in include_from_node1 at ./loading.jl:134
 in reload_path at ./loading.jl:158
 in _require at ./loading.jl:70
 in require at ./loading.jl:53
tomasaschan commented 9 years ago

Thanks for the report; I'll take a look at it as soon as I have time, but unfortunately probably not before this weekend. PR's are very welcome (although I guess you specifically are at least as busy as I am!) :)

tomasaschan commented 9 years ago

@ViralBShah: Using the latest master of Julia, Gadfly and Contour (as well as a couple of other dependencies of Gadfly) I can't reproduce the problem:

xs = collect(Float64, -pi:0.1:pi)
ys = copy(x)
zs = [sin(x) * cos(y) for x in xs, y in ys]

using Gadfly
plot(x=xs, y=ys, z=zs, Geom.contour)

works and produces the expected plot. What versions are you on? Can you give a code sample that reproduces the error?

Edit: OK, after Pkg.free("Contour") I can reproduce. I'll tag a new version promptly; can you do Pkg.update() (in a little while) and see if the problem is solved?

ViralBShah commented 9 years ago

Thanks! I was using the tagged versions.

ViralBShah commented 9 years ago

The error was on using Gadfly, and this one is now fixed. Failing in Grid.jl now.

tomasaschan commented 9 years ago

Great! Thanks again for the report!