search

JuliaGeometry / Contour.jl

Calculating contour curves for 2D scalar fields in Julia
Other
43 stars 13 forks source link

Make Contour.jl compatible with GLVisualize #27

Closed SimonDanisch closed 8 years ago

SimonDanisch commented 8 years ago

It already would work out of the box, but it's nicer if Contour.jl supports Float32 and FixedSizeArrays/GeometryTypes for points. A little teaser from GLVisualize next2 branch:

image

Generated with this code: https://github.com/JuliaGL/GLVisualize.jl/blob/next2/examples/contours.jl Note, that FixedSizeArrays needs Julia 0.4 ...

Best, Simon

codecov-io commented 8 years ago

Current coverage is 96.74%

Branch #27 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

darwindarak commented 8 years ago

That looks awesome! Thanks!

tomasaschan commented 8 years ago

Nice, thanks!

Since this deprecates support for 0.3, we should carefully test what the latest commit that works on 0.3 is and tag a release there, before tagging a new release that includes this.

tomasaschan commented 8 years ago

By the way, @SimonDanisch: You're the first user outside of Gadfly (and myself for a small part of my master's thesis) that I know of that uses this library. What do you think of the API? Was it easy to work with?

SimonDanisch commented 8 years ago

I think it's pretty nice! By the way, I'm working on ways to represent the xyz points uniformly independant from the memory layout the user prefers.... This way it would be possible to allow the user more easily to switch between (x::Range, y::Range, z::Matrix), (x::Matrix, y::Matrix, z::Matrix), (xyz::Matrix{Point3}), while only writing one version of the algorithm. I'm not sure how well this might work for your algorithm, but this is the PR you should watch out for: https://github.com/simonster/StructsOfArrays.jl/pull/3