JuliaGeometry / Contour.jl

Calculating contour curves for 2D scalar fields in Julia
Other
43 stars 13 forks source link

Fix depwarn in test #35

Closed ranjanan closed 8 years ago

ranjanan commented 8 years ago

cs -> levels(cs)

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 88.406% when pulling b1af2c52a925e7d9a1a235a6f5c4443a3324286c on ranjanan:RA/depwarn into 8b59af7312eb61ea5c7fe297bd811696656a096d on tlycken:master.

codecov-io commented 8 years ago

Current coverage is 88.40% (diff: 100%)

Merging #35 into master will decrease coverage by 2.89%

@@             master        #35   diff @@
==========================================
  Files             1          1          
  Lines           138        138          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            126        122     -4   
- Misses           12         16     +4   
  Partials          0          0          

Powered by Codecov. Last update 8b59af7...b1af2c5

tomasaschan commented 8 years ago

Thanks - this should probably have been part of #30 :smile:

I suspect that we should probably change the next line from c.lines to lines(c) too, to be consistent.

This test is actually supposed to throw a warning; it's there to ensure that the old API works during its deprecation period. I am actually working on removing it altogether - but this PR alerted me to the fact that that change wasn't pushed yet; see de133850.

Thanks anyway!

ranjanan commented 8 years ago

Ah I see, I didn't know it was meant to throw a depwarn. Thanks!

Would you mind adding a comment above that particular test please?

tomasaschan commented 8 years ago

Well, no - because that test is removed on the latest master :P

If you do Pkg.checkout("Contour") to get it, you won't see that warning anymore.

ranjanan commented 8 years ago

Cool, you're right. 😄 Would you mind tagging a new release then? Or do you want to wait on that?

tomasaschan commented 8 years ago

I'm working on it: https://github.com/JuliaLang/METADATA.jl/pull/5901