JuliaGeometry / Contour.jl

Calculating contour curves for 2D scalar fields in Julia

Other

43 stars 13 forks source link

fix deprecations and drop 0.4 support #38

Closed KristofferC closed 7 years ago

KristofferC commented 7 years ago

Also move from FixedSizeArrays which is deprecated for StaticArrays.

codecov-io commented 7 years ago

Codecov Report

Merging #38 into master will not change coverage. The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files           1        1           
  Lines         135      135           
=======================================
  Hits          122      122           
  Misses         13       13

Impacted Files	Coverage Δ
src/Contour.jl	`90.37% <66.66%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37df0d5...15c5089. Read the comment docs.

coveralls commented 7 years ago

Coverage remained the same at 90.37% when pulling 15c50897b4e44619dcbeef8387637b9f7bc5806b on KristofferC:kc/static into 37df0d5ebc23d14bd9783916beed35d8e8690b0a on tlycken:master.

coveralls commented 7 years ago

Coverage remained the same at 90.37% when pulling 15c50897b4e44619dcbeef8387637b9f7bc5806b on KristofferC:kc/static into 37df0d5ebc23d14bd9783916beed35d8e8690b0a on tlycken:master.

coveralls commented 7 years ago

Coverage remained the same at 90.37% when pulling 15c50897b4e44619dcbeef8387637b9f7bc5806b on KristofferC:kc/static into 37df0d5ebc23d14bd9783916beed35d8e8690b0a on tlycken:master.

KristofferC commented 7 years ago

Holy @coveralls Batman

tomasaschan commented 7 years ago

Thanks for this PR!

Have you seen #37? Would you like to (help) take over?

KristofferC commented 7 years ago

I did not see that. I invited you to JuliaGeometry so perhaps you can transfer the repo there? I'm happy doing simple stuff like updating deprecations and do tagging but I don't really know anything about the code itself so it will likely be limited to that.