JuliaGeometry / Contour.jl

Calculating contour curves for 2D scalar fields in Julia
Other
44 stars 13 forks source link

Adjust relative scaling of the axis (addresses #1) #7

Closed darwindarak closed 10 years ago

darwindarak commented 10 years ago

The output vertices should now be relative to the user-provided axes now. Still need to modify the tests to make it work with the change though.

tomasaschan commented 10 years ago

This looks good to my eyes, but I haven't test-run it yet. Of course we should make sure it works with the tests. I think basically just removing the interpolating step in the test suite should do it.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 438158d3d5a6f332d7406eb6e2df9c9c88ea2b45 on fix-axis-scaling into 1ec95cdba19c2aed9da7c45a1e6ac23adb83dcfe on master.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-11.54%) when pulling 370bcf7bd939f89e935671c2a27c580ebb09a02b on fix-axis-scaling into 1ec95cdba19c2aed9da7c45a1e6ac23adb83dcfe on master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling e3ccdfe69ffff51e7cb126aa40812c5069f8c537 on fix-axis-scaling into 1ec95cdba19c2aed9da7c45a1e6ac23adb83dcfe on master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling a10eff9ef0af74bb1ec5249081034ccd3b584293 on fix-axis-scaling into 1ec95cdba19c2aed9da7c45a1e6ac23adb83dcfe on master.

darwindarak commented 10 years ago

I think this is basically done for now. What do you think?

tomasaschan commented 10 years ago

Looks good to me!