Create Project.toml - Githubissues

JuliaGeometry / CoordinateTransformations.jl

A fresh approach to coordinate transformations...

Other

179 stars 25 forks source link

Closed asinghvi17 closed 4 years ago

asinghvi17 commented 4 years ago

This will make the package devable on 1.4. I kind of want to try and integrate GeometryTypes with this, it shouldn't be too hard at all...

c42f commented 4 years ago

Thanks! Looks like you need an [extras] section for the tests?

asinghvi17 commented 4 years ago

Yep, looks like I forgot that. Thanks!

c42f commented 4 years ago

Tests have failed still. Looks like you also need ForwardDiff in extras. I also suggest removing REQURE and test/REQURE as those will be obsolete.

asinghvi17 commented 4 years ago

CI is green...LGTM from my end!

mcabbott commented 4 years ago

Came here to fix this, but you did it first!

However something still seems weird, as 0.5.0 is not listed here, and what is listed has tighter bounds on Compat.jl, which was causing me problems:

Perhaps it needs to be re-registered?

asinghvi17 commented 4 years ago

Yeah, we should change bounds in the registry

mcabbott commented 4 years ago

Or simply release 0.5.1, I guess.

c42f commented 4 years ago

Yes, we should upgrade it to a new version 0.5.1.

Would be nice to aim for a 1.0 actually. Glancing over the issues, there's only #25 which really obviously needs something done about it.

mcabbott commented 4 years ago

That issue indeed looks close. But even if you do 1.0 tomorrow, it would be nice for 0.5.1 to exist with reasonable bounds, I think.

c42f commented 4 years ago

Absolutely agreed, I'll try to arrange 0.5.1.