Closed jw3126 closed 3 years ago
I think it is good to go.
Merge?
Thanks for this. By the way, if you wanted to correct the situation to have a more normal definition of this angle, overriding getproperty
with some more explicit names would likely help a lot.
See also #25 for other options for improving the situation.
Regardless, thanks for the PR!
Thanks. We may want to switch conventions in the future - but it is good to at least document what is implemented :)
Is this good to go?