JuliaGeometry / DelaunayTriangulation.jl

DelaunayTriangulation.jl: A Julia package for Delaunay triangulations and Voronoi tessellations in the plane
https://juliageometry.github.io/DelaunayTriangulation.jl/
MIT License
69 stars 6 forks source link

Allow `set_point!` to work for e.g. StaticArrays and Point2f, and fix Float32 examples for many cases #74

Closed DanielVandH closed 1 year ago

DanielVandH commented 1 year ago

set_point! was fixed by just changing the general vector methods, and specialising the Vector case.

The Float32 examples were fixed by just changing how the triangle_area is computed: The original formula is used, and then if it is not positive try another accurate formula. Moreover, we now convert to Float64 to that only Float64 are used in these computations. This fixes #72. Will need to address #73 soon.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 78.57% and project coverage change: -0.05% :warning:

Comparison is base (51e9deb) 93.49% compared to head (aa99da3) 93.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #74 +/- ## ========================================== - Coverage 93.49% 93.44% -0.05% ========================================== Files 73 73 Lines 5439 5450 +11 ========================================== + Hits 5085 5093 +8 - Misses 354 357 +3 ``` | [Files Changed](https://app.codecov.io/gh/DanielVandH/DelaunayTriangulation.jl/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+VandenHeuvel) | Coverage Δ | | |---|---|---| | [src/data\_structures/statistics.jl](https://app.codecov.io/gh/DanielVandH/DelaunayTriangulation.jl/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+VandenHeuvel#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9zdGF0aXN0aWNzLmps) | `78.63% <70.00%> (-0.48%)` | :arrow_down: | | [src/interfaces/points.jl](https://app.codecov.io/gh/DanielVandH/DelaunayTriangulation.jl/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+VandenHeuvel#diff-c3JjL2ludGVyZmFjZXMvcG9pbnRzLmps) | `94.18% <100.00%> (+0.13%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.