JuliaGeometry / GeometricalPredicates.jl

Fast and robust 2D & 3D incircle/intriangle/etc. for Julia
Other
57 stars 14 forks source link

Package does not Compile for Julia v1.0 #29

Closed pfarndt closed 6 years ago

pfarndt commented 6 years ago

There are quite a few warnings when compiling the package under Julia v0.7, which let the package compilation break under Julia v1.0.

skariel commented 6 years ago

I'll look into it

dkarrasch commented 6 years ago

It's because the current master branch is not tagged (#28), so when you ]add GeometricalPredicates the lastly tagged version is installed and used (which was written for Julia 0.6). The master branch did receive updates which make it work, but this is invisible to the package manager. If you really need it in Julia 1.0 until a new version release, you could ]add GeometricalPredicates#master.

dkarrasch commented 6 years ago

Fixed on v0.2.0. Just update with the package manager.