simplify snip signature

JuliaGeometry / GeometryBasics.jl

Basic Geometry Types

MIT License

164 stars 54 forks source link

simplify snip signature #166

Closed piever closed 2 years ago

piever commented 2 years ago

As this methods seemed very costly in https://github.com/JuliaPlots/Makie.jl/discussions/1636, I thought it could be less taxing on the compiler to remove unused type parameters.

sjkelly commented 2 years ago

Seems reasonable. Though the CI seems to have bitrotted? @piever I notice you are the lead dev for StructArrays.jl. Any insight on this? https://github.com/JuliaGeometry/GeometryBasics.jl/runs/5034017528?check_suite_focus=true

piever commented 2 years ago

Sure, I've added #167 that fixes that (it was some usage of internals of StructArrays), even though that still does not fix CI (see here), but that issue at least seems unrelated to StructArrays.

sjkelly commented 2 years ago

Ah thanks for the force push :)