search

JuliaGeometry / GeometryBasics.jl

Basic Geometry Types
MIT License
165 stars 54 forks source link

Pass input types to mesh #186

Closed ffreyer closed 1 year ago

ffreyer commented 1 year ago

For https://github.com/MakieOrg/Makie.jl/pull/2573

Adjusts mesh generating functions to keep the input element type around, rather than converting to Float32

SimonDanisch commented 1 year ago

So, these kind of methods were written specifically to convert to OpenGL datatypes by default. If one doesn't want them, the mesh should just be created with mesh(...) or Mesh(...) directly...

ffreyer commented 1 year ago

Sounds like they should be gl_normal_mesh etc then... But I can also change the default conversions in Makie I guess