search

JuliaGeometry / GeometryBasics.jl

Basic Geometry Types
MIT License
165 stars 54 forks source link

fix geointerface conversion performance #192

Closed rafaqz closed 1 year ago

rafaqz commented 1 year ago

This PR fixes type instability in GeoInterface.jl conversion methods.

There are still some issues with TupleView, but I think this is internal to GeometryBasics.jl

There is more that could be done with e.g. Polygon and MultiPolygon, but that can wait for #173 as the types are currently too complicated.

rafaqz commented 1 year ago

Thanks! feel free to merge and tag then, I don't have merge rights in this org

rafaqz commented 1 year ago

Ok this is rebased to keep the changes not included in #193

(oops it actually contains all of #193, so to merge after that :sweat:)

Instead I'll push this to the other PR