JuliaGeometry / GeometryBasics.jl

Basic Geometry Types
MIT License
165 stars 54 forks source link

Add Extents.extent method for Rect2 #196

Closed felixcremer closed 1 year ago

felixcremer commented 1 year ago

This has been pirated in Tyler and should rather live in GeometryBasics. This would enable us to use this method in PyramidScheme without having to depend on Tyler for example.

I put the definition into the GeoInterface file because for me the Extents is an extension of the GeoInterface.

I am not sure, whether it would make sense to also provide the extent functionality also for higher dimensional rectangles or other geometry types, but the Rect2 is needed for the subsetting in Tyler.

@rafaqz

rafaqz commented 1 year ago

Thanks! Good to fix that type piracy.

(Also Extends doesnt actually extend GeoInterface, its not really Geo specific)

felixcremer commented 1 year ago

Bump