dont use macro for aliases and introduce more variants (Float64 -> d, UInt -> ui)

JuliaGeometry / GeometryBasics.jl

Basic Geometry Types

MIT License

165 stars 54 forks source link

dont use macro for aliases and introduce more variants (Float64 -> d, UInt -> ui) #214

Closed SimonDanisch closed 4 months ago

SimonDanisch commented 6 months ago

This PR makes all aliases recognizable by the linter and adds missing ones.

SimonDanisch commented 6 months ago

Weird, this makes the texture atlas hashing tests fail in Makie... Not sure how, since this should only change aliases - and looks like all involved aliases seem to work correctly. Will need some further investigation.

Meanwhile, we should think about adding even more aliases here for the other primitives? Or also for e.g. Int32 etc? Although I think that goes a bit too far, but then again it would make it more consistent.

putianyi889 commented 6 months ago

As for the docstrings, it's now possible to generate one docstring for each alias. Then there should be a section on doc that clarifies the meaning of the suffixes.