search

JuliaGeometry / GeometryTypes.jl

Geometry types for Julia
Other
67 stars 41 forks source link

Fix tests and most deprecations on v0.7-alpha #130

Closed rdeits closed 6 years ago

rdeits commented 6 years ago

The only outright failures on v0.7 were where we were abusing sub2ind((v,), j, i) by passing it a 1-dimensional first argument and then indexing with two dimensions. I replaced those calls with (i - 1) * v + j.

The remaining deprecations are all due to constructors no longer falling back to convert methods. I'm still trying to figure out the right way to handle that: https://discourse.julialang.org/t/recommended-style-for-conversion-vs-constructors-in-v0-7/11561

rdeits commented 6 years ago

Ok, I think all the v0.7 issues are resolved, but getting CI to pass will require a new tag of StaticArrays, so I marked them as allowed failures for now.

rdeits commented 6 years ago

Also, coverage submission has been turned off since pre-v0.6, so I turned it back on :wink:

SimonDanisch commented 6 years ago

nice, thanks a lot!

SimonDanisch commented 6 years ago

Do we need to tag StaticArrays to make this pass on 0.7?

rdeits commented 6 years ago

Yeah, but we also need the fixes from https://github.com/JuliaArrays/StaticArrays.jl/pull/433 as well. I'm ok with leaving this open until that's ready or merging it with v0.7 still marked as an allowed failure

SimonDanisch commented 6 years ago

Ok let's wait for https://github.com/JuliaArrays/StaticArrays.jl/pull/441 and tag !

SimonDanisch commented 6 years ago

do we want to include the new tag in the require?

SimonDanisch commented 6 years ago

lets just merge this, I got to annoyed by too strictly versioned packages lately ;)

SimonDanisch commented 6 years ago

Thanks!