search

JuliaGeometry / GeometryTypes.jl

Geometry types for Julia
Other
67 stars 41 forks source link

Fix documentation deployment #179

Closed cserteGT3 closed 5 years ago

cserteGT3 commented 5 years ago

As described in #177, deploying the documentation fails. I changed the documentation deploying script to use a Documentation stage (based on a template from PkgSkeleton). In the docs environment Documenter.jl is pinned to v0.19.0.

cserteGT3 commented 5 years ago

Updated Documenter to v0.23.x which resolved the failing build.

sjkelly commented 5 years ago

This looks good, except I don't think we want to commit the Manifest file. I think the default generator in Documenter or PkgTemplates actually adds it into a .gitignore as well.

cserteGT3 commented 5 years ago

Removed it. I didn't know that it's not required.

sjkelly commented 5 years ago

Thanks for the contribution!

To clarify: the manifest is autogenerated from the project.toml, so unless there is some need for a specific commit or branch of a dependency we don't include it.