JuliaGeometry / GeometryTypes.jl

Geometry types for Julia
Other
67 stars 41 forks source link

Fix cuboid face orientation #183

Closed CarpeNecopinum closed 5 years ago

CarpeNecopinum commented 5 years ago

Currently, the faces obtained by decompose(Face, HyperRectangle{3}) are oriented towards the positive coordinate axes (assuming counter-clockwise winding order).

Since they enclose a volume, it would however make more sense if they pointed outwards (which would help with e.g. #144 or rendering with backface-culling enabled).

This PR thus fixes the orientation of the faces and adds a test to document this.

SimonDanisch commented 5 years ago

Thank you :)