search

JuliaGeometry / GeometryTypes.jl

Geometry types for Julia
Other
67 stars 41 forks source link

OffsetInteger operations incorrect #186

Closed goretkin closed 4 years ago

goretkin commented 4 years ago

I think the intent of OffsetInteger is that it preserves all the structure of integers, but the definitions at

https://github.com/JuliaGeometry/GeometryTypes.jl/blob/c42a2b336ac0e8135f71f4c0a48f3766ce5127e2/src/faces.jl#L26-L35

don't do this.

The operations shouldn't happen on the underlying value, but on the "effective" value.

SimonDanisch commented 4 years ago

Hm good point... I will see if there are any regression by fixing this!

goretkin commented 4 years ago

Thanks for looking at the PR!