search

JuliaGeometry / OldMeshes.jl

A collection of tools for working with Meshes
Other
20 stars 12 forks source link

Add exportBinaryStl #41

Closed dhoegh closed 9 years ago

dhoegh commented 9 years ago

Hi I have used the package for some decent work and I thought I would contribute with an exportBinaryStl function. Please correct me if you find anything, I do not usually deal with binary data so I made this as a challenge for my self.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.78%) to 45.39% when pulling 99b25de728fa962a92c4de995152c6704f99de1b on dhoegh:patch-1 into 6d65c5b840d55d4e7310e6d5e78fa784aaf1ba46 on JuliaGeometry:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.91%) to 47.08% when pulling 00f6f7b67637d578e7a962ce590aa30a875ee3cd on dhoegh:patch-1 into 6d65c5b840d55d4e7310e6d5e78fa784aaf1ba46 on JuliaGeometry:master.

dhoegh commented 9 years ago

Should I resubmit this at MeshIO.jl, as it seams to be the future of MeshIO in julia? cc @SimonDanisch, @KristofferC, @sjkelly

SimonDanisch commented 9 years ago

That would be great! Sorry if things are a little messy right now, but we're trying to prototype some nice mesh architecture without much time at hand! I hope the others agree, that IO shouldn't be part of Meshes. IO will become very big, if support for more and more file types will be added.

sjkelly commented 9 years ago

Thanks for doing this! I think this should be in both packages for now until MeshIO is published.

SimonDanisch commented 9 years ago

Agreed! Tests will follow ;)

2015-05-23 15:28 GMT+02:00 Steve Kelly notifications@github.com:

Thanks for doing this! I think this should be in both packages for now until MeshIO is published.

— Reply to this email directly or view it on GitHub https://github.com/JuliaGeometry/Meshes.jl/pull/41#issuecomment-104895596 .

sjkelly commented 9 years ago

The 0.4 failure is also related to tuples and in a different part of the code.