Closed sethaxen closed 1 year ago
Merging #108 (b519d49) into main (b04badb) will decrease coverage by
0.23%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 98.67% 98.44% -0.24%
==========================================
Files 1 1
Lines 227 193 -34
==========================================
- Hits 224 190 -34
Misses 3 3
Impacted Files | Coverage Δ | |
---|---|---|
src/Quaternion.jl | 98.44% <100.00%> (-0.24%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I wonder also if we should remove sign_abs. We don't use it internally, and something like sign_abs iss general-purpose and unrelated to quaternions.
I agree with removing sign_abs
(normalizea
).
For that matter, should we remove argq
? It likewise is not part of the API and is nowhere used internally.
For that matter, should we remove
argq
? It likewise is not part of the API and is nowhere used internally.
I think the function can be removed too. I also think that the name of the function is not common and inappropriate.
@hyrodium this should be ready for final review.
This PR primarily removes the
:norm
field ofQuaternion
and updates all code and tests accordingly (fixes #60). It also:normalize
overload in favor ofsign
. (fixes #69)normalizea
tosign_abs
(exported)~normalizea
argq
normalizeq
(only used internally forargq
and makes no sense apart from it)The first 2 are breaking. ~I wonder also if we should remove
sign_abs
. We don't use it internally, and something likesign_abs
iss general-purpose and unrelated to quaternions.~Supersedes #75