JuliaGeometry / Quaternions.jl

A Julia implementation of quaternions
https://juliageometry.github.io/Quaternions.jl
MIT License
116 stars 37 forks source link

Remove rotation-related functions #111

Closed hyrodium closed 1 year ago

hyrodium commented 1 year ago

This PR removes rotation-related functions. (closes #86) ~Note that the documentation is failing to build because Rotations.jl assumes Quaternion has the norm field. I'd like to wait for https://github.com/JuliaGeometry/Rotations.jl/pull/243.~

Edit: The documentation does not depend on Rotations.jl now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #111 (b7aa354) into main (9c62d64) will increase coverage by 0.76%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   98.44%   99.20%   +0.76%     
==========================================
  Files           1        1              
  Lines         193      126      -67     
==========================================
- Hits          190      125      -65     
+ Misses          3        1       -2     
Impacted Files Coverage Δ
src/Quaternion.jl 99.20% <ø> (+0.76%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hyrodium commented 1 year ago

@sethaxen Thank you for the corrections, and sorry for my poor English:sweat_smile:. I think we can improve the documentation after the release of v0.7.0 if there are no major problems in this PR.

sethaxen commented 1 year ago

I think we can improve the documentation after the release of v0.7.0 if there are no major problems in this PR.

You're right, no problem at all! LGTM.