search

JuliaGeometry / Quaternions.jl

A Julia implementation of quaternions
https://juliageometry.github.io/Quaternions.jl
MIT License
116 stars 37 forks source link

Implement more base methods #121

Closed sethaxen closed 1 year ago

sethaxen commented 1 year ago

I went through https://github.com/JuliaLang/julia/blob/v1.8.3/base/complex.jl and implemented here for Quaternion all overloads that are there implemented for Complex. All of these methods resulted in a MethodError before this PR, so this is a non-breaking change.

The one overload I did not implement is hash, which I would need to take some more time to understand.

codecov[bot] commented 1 year ago

Codecov Report

Merging #121 (30fe4d1) into main (3be75e4) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          123       135   +12     
=========================================
+ Hits           123       135   +12
Impacted Files Coverage Δ
src/Quaternion.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more