Closed sethaxen closed 1 year ago
Merging #121 (30fe4d1) into main (3be75e4) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 123 135 +12
=========================================
+ Hits 123 135 +12
Impacted Files | Coverage Δ | |
---|---|---|
src/Quaternion.jl | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I went through https://github.com/JuliaLang/julia/blob/v1.8.3/base/complex.jl and implemented here for
Quaternion
all overloads that are there implemented forComplex
. All of these methods resulted in aMethodError
before this PR, so this is a non-breaking change.The one overload I did not implement is
hash
, which I would need to take some more time to understand.