Closed hyrodium closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
89232ef
) 100.00% compared to head (538a840
) 100.00%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Abstract
This PR adds more methods to
quat
.Before this PR
After this PR
This behavior is consistent with
Base.complex
.How to find the methods to add
I have confirmed the methods with the
methods
function.Note that this PR does not contain methods with
SparseArrays
because there were some performance degressions.The above definition
Quaternions.quat(S::SparseMatrixCSC)
is from:https://github.com/JuliaSparse/SparseArrays.jl/blob/bd2bda8f45ed71374223068b0a0daa2b169071c9/src/sparsematrix.jl#L984