search

JuliaGeometry / Quaternions.jl

A Julia implementation of quaternions
https://juliageometry.github.io/Quaternions.jl
MIT License
115 stars 37 forks source link

Reorganize tests #72

Closed sethaxen closed 2 years ago

sethaxen commented 2 years ago

The current tests are a mess, and much of the code isn't tested. This PR completely reorganizes the tests, leaving a lot of empty test sets to mark where tests are needed. It doesn't add any tests; these should be handled in future PRs.

Because this PR changes every line of the test code, it also runs JuliaFormatter on the test files with BlueStyle.

codecov[bot] commented 2 years ago

Codecov Report

Merging #72 (def2401) into master (3b3bbe6) will decrease coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   55.31%   55.04%   -0.28%     
==========================================
  Files           3        3              
  Lines         367      367              
==========================================
- Hits          203      202       -1     
- Misses        164      165       +1
Impacted Files Coverage Δ
src/Quaternion.jl 85.32% <0.00%> (-0.55%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b3bbe6...def2401. Read the comment docs.

sethaxen commented 2 years ago

85.32% <0.00%> (-0.55%)

I'm not sure the reason for the change of the coverage rate, but we can add more tests in another PR.

EDIT: https://app.codecov.io/gh/JuliaGeometry/Quaternions.jl/compare/72/changes#D1L15

Yes, this is because sample was using this constructor, but it was never explicitly tested. All the constructors need tests in a later PR.