JuliaGeometry / Quaternions.jl

A Julia implementation of quaternions
https://juliageometry.github.io/Quaternions.jl
MIT License
115 stars 37 forks source link

Add missing tests #74

Closed sethaxen closed 2 years ago

sethaxen commented 2 years ago

The goal of this PR is to get (close to) complete coverage by adding missing tests. for already-implemented functionality.

codecov[bot] commented 2 years ago

Codecov Report

Merging #74 (a779f44) into master (247d149) will increase coverage by 38.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #74       +/-   ##
===========================================
+ Coverage   58.94%   97.12%   +38.18%     
===========================================
  Files           3        3               
  Lines         397      383       -14     
===========================================
+ Hits          234      372      +138     
+ Misses        163       11      -152     
Impacted Files Coverage Δ
src/DualQuaternion.jl 95.23% <100.00%> (+73.45%) :arrow_up:
src/Octonion.jl 96.15% <100.00%> (+68.10%) :arrow_up:
src/Quaternion.jl 98.50% <100.00%> (+10.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 247d149...a779f44. Read the comment docs.

sethaxen commented 2 years ago

This is ready for review now. A few notes:

sethaxen commented 2 years ago

Thanks for the very thorough review!