search

JuliaGeometry / Quaternions.jl

A Julia implementation of quaternions
https://juliageometry.github.io/Quaternions.jl
MIT License
116 stars 37 forks source link

Add `imag_part` which returns `Tuple` #77

Closed hyrodium closed 2 years ago

hyrodium commented 2 years ago

This PR fixes #61.

codecov[bot] commented 2 years ago

Codecov Report

Merging #77 (c81cd0e) into master (ffe1bf8) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files           3        3           
  Lines         383      383           
=======================================
  Hits          372      372           
  Misses         11       11
Impacted Files Coverage Δ
src/DualQuaternion.jl 95.23% <100.00%> (ø)
src/Octonion.jl 96.15% <100.00%> (ø)
src/Quaternion.jl 98.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffe1bf8...c81cd0e. Read the comment docs.

hyrodium commented 2 years ago

Can you make sure all lines changed are covered by tests? I know these will likely be replaced by https://github.com/JuliaGeometry/Quaternions.jl/pull/74, but this way we make sure this PR isn't breaking.

I thought this PR can wait for #74, but okay, I'll add some tests!

sethaxen commented 2 years ago

I thought this PR can wait for #74, but okay, I'll add some tests!

That's fine too! I plan to finish #74 this weekend (only dual quaternion tests left)

hyrodium commented 2 years ago

Okay, I'll wait for that! #73 as well.