Closed hyrodium closed 1 year ago
Btw, quat
should be renamed to quaternion
just like complex
vs Complex
?
I agree that quat(some_array)
should "quaternionify" the array elements by analogy to complex
. complex
and Complex
differ in that complex
complexifies the inputs, while Complex
is a constructor, and I think we want the same relationship between quat
and Quaternion
.
Btw,
quat
should be renamed toquaternion
just likecomplex
vsComplex
?
Hmm, maybe, for consistency. Although, quat
is a useful abbrevation and is likely to be used in code, so I'm inclined to keep it.
The function
quat
should be similar tocomplex
, but the behavior is different.I think
quat([1,2,3,4])
should be[Quaternion{Int64}(1,0,0,0), Quaternion{Int64}(2,0,0,0), Quaternion{Int64}(3,0,0,0), Quaternion{Int64}(4,0,0,0)]
.