search

JuliaGeometry / Rotations.jl

Julia implementations for different rotation parameterizations
https://juliageometry.github.io/Rotations.jl
MIT License
176 stars 44 forks source link

Remove dependency on `Statistics` and `src/mean.jl` #255

Closed hyrodium closed 1 year ago

hyrodium commented 1 year ago

mean_rotation should be implemented in the future (https://github.com/JuliaGeometry/Rotations.jl/issues/178), but it does not imply adding methods to Statistics.mean. This PR removes the unnecessary dependency on Statistics.jl and remove src/mean.jl for now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #255 (afb44ae) into master (2f9be71) will increase coverage by 0.69%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   88.82%   89.51%   +0.69%     
==========================================
  Files          16       15       -1     
  Lines        1602     1593       -9     
==========================================
+ Hits         1423     1426       +3     
+ Misses        179      167      -12
Impacted Files Coverage Δ
src/euler_types.jl 92.27% <100.00%> (+0.01%) :arrow_up:
src/unitquaternion.jl 97.56% <100.00%> (+0.02%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

juliohm commented 1 year ago

Thank you for the improvement @hyrodium 🙏🏽