search

JuliaGeometry / Rotations.jl

Julia implementations for different rotation parameterizations
https://juliageometry.github.io/Rotations.jl
MIT License
176 stars 44 forks source link

Add more elementary functions #266

Closed hyrodium closed 11 months ago

hyrodium commented 11 months ago

This PR fixes #234 and #164.

codecov[bot] commented 11 months ago

Codecov Report

Merging #266 (149cc7a) into master (4240829) will increase coverage by 0.48%. The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   89.93%   90.42%   +0.48%     
==========================================
  Files          17       17              
  Lines        1619     1660      +41     
==========================================
+ Hits         1456     1501      +45     
+ Misses        163      159       -4
Files Changed Coverage Δ
src/Rotations.jl 100.00% <ø> (ø)
src/angleaxis_types.jl 97.93% <ø> (+3.87%) :arrow_up:
src/core_types.jl 95.65% <ø> (-0.07%) :arrow_down:
src/elementary_functions.jl 98.38% <98.38%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hyrodium commented 11 months ago

Oh, we are missing cbrt(::Quaternion) in https://github.com/JuliaGeometry/Quaternions.jl/pull/56 because cbrt(::Complex) is not implemented yet (https://github.com/JuliaLang/julia/issues/36534).