search

JuliaGeometry / TetGen.jl

Julia's TetGen wrapper
MIT License
42 stars 9 forks source link

Fixing README example #27

Closed jlchan closed 3 years ago

jlchan commented 3 years ago

Removed outdated import. Should fix https://github.com/JuliaGeometry/TetGen.jl/issues/26, at least for Mac.

codecov[bot] commented 3 years ago

Codecov Report

Merging #27 (532f498) into master (e2bcc2b) will increase coverage by 0.23%. The diff coverage is n/a.

:exclamation: Current head 532f498 differs from pull request most recent head 24ca039. Consider uploading reports for the commit 24ca039 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   87.50%   87.73%   +0.23%     
==========================================
  Files           6        6              
  Lines         368      375       +7     
==========================================
+ Hits          322      329       +7     
  Misses         46       46
Impacted Files Coverage Δ
src/jltetgenio.jl 78.70% <0.00%> (+0.19%) :arrow_up:
src/rawtetgenio.jl 89.95% <0.00%> (+0.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2bcc2b...24ca039. Read the comment docs.

j-fu commented 3 years ago

... just tried to check this: AbstractPlotting needs to be removed as well.

But I am getting the "double free or corruption (!prev)" error from #26 which I would like to hunt down before updating, but this is not a quick one... Would then put that example into the runtest as well...

jlchan commented 3 years ago

Thanks for the catch. I've removed it in this PR.