search

JuliaGeometry / VoronoiDelaunay.jl

Fast and robust Voronoi & Delaunay tessellation creation with Julia
Other
124 stars 26 forks source link

v0.4 deprecations #12

Closed swt30 closed 8 years ago

swt30 commented 9 years ago

Removes some deprecation warnings that show up in julia v0.4. Adds a dependency on Compat.jl to keep compatibility with 0.3.

skariel commented 8 years ago

this needs some merging work, can you rebase? Otherwise I could do these changes manually

swt30 commented 8 years ago

All done

skariel commented 8 years ago

Merged, thanks!

swt30 commented 8 years ago

Worth tagging a new release as well?

skariel commented 8 years ago

yes, I don't remember now how it's done though... I can do it later when I have some time to re-learn this, or you can do this too if you want :)

swt30 commented 8 years ago

I can't bump the version because it's done with a git tag. I think you just need to make sure your local copy of the repository is up to date, then start julia and do Pkg.tag("VoronoiDelaunay", :patch) followed by Pkg.publish() and opening a pull request at the address given. This will mark it as version 0.0.2 and then anyone else using the package will get the latest copy :)

On Wed, 10 Feb 2016 at 10:05 Ariel Keselman notifications@github.com wrote:

yes, I don't remember now how it's done though... I can do it later when I have some time to re-learn this, or you can do this too if you want :)

— Reply to this email directly or view it on GitHub https://github.com/JuliaGeometry/VoronoiDelaunay.jl/pull/12#issuecomment-182287919 .

r-chris commented 8 years ago

Hi there @skariel if you find the time it would probably be a good idea to follow @swt30's suggestion here and bump the version upstream.