JuliaGeometry / VoronoiDelaunay.jl

Fast and robust Voronoi & Delaunay tessellation creation with Julia
Other
124 stars 26 forks source link

Task iteration is now deprecated #31

Closed juliohm closed 7 years ago

juliohm commented 7 years ago

In Julia v0.6, the package is emitting a set of warnings, but I am not sure how I can fix them:

using VoronoiDelaunay

tess = DelaunayTessellation()
push!(tess, Point(1.5, 1.5))
push!(tess, Point(1.8, 1.8))

for e in delaunayedges(tess)
  a = geta(e); b = getb(edge)
end

WARNING: Task iteration is now deprecated. Use Channels for inter-task communication. A for-loop on a Channel object is terminated by calling close on the object. Stacktrace: [1] depwarn(::String, ::Symbol) at ./deprecated.jl:70 [2] start at ./deprecated.jl:977 [inlined] [3] anonymous at ./:? [4] include_from_node1(::String) at ./loading.jl:569 [5] include(::String) at ./sysimg.jl:14 [6] process_options(::Base.JLOptions) at ./client.jl:305 [7] _start() at ./client.jl:371 while loading /home/juliohm/Desktop/foo.jl, in expression starting on line 7 WARNING: consume is now deprecated. Use Channels for inter-task communication. Stacktrace: [1] depwarn(::String, ::Symbol) at ./deprecated.jl:70 [2] consume(::Task) at ./deprecated.jl:946 [3] done at ./deprecated.jl:983 [inlined] [4] anonymous at ./:? [5] include_from_node1(::String) at ./loading.jl:569 [6] include(::String) at ./sysimg.jl:14 [7] process_options(::Base.JLOptions) at ./client.jl:305 [8] _start() at ./client.jl:371 while loading /home/juliohm/Desktop/foo.jl, in expression starting on line 7

Could you please take a look at this? I am relying on VoronoiDelaunay.jl heavily for my next package :)

skariel commented 7 years ago

fixed in latest master

juliohm commented 7 years ago

Awesome, thank you.