search

JuliaGeometry / VoronoiDelaunay.jl

Fast and robust Voronoi & Delaunay tessellation creation with Julia
Other
123 stars 26 forks source link

Loosen dependency minimum requirements #33

Closed tkelman closed 7 years ago

tkelman commented 7 years ago

Most users will be on latest versions from Pkg.update, minimum versions should document the lowest versions that would work correctly rather than what you happened to test with. Via Pkg.pin, VoronoiDelaunay's tests passed fine on master against Colors 0.7.0 and GeometricalPredicates 0.0.5

robertdj commented 7 years ago

I agree. One question though: As I recall, GP v0.0.5 has a lot of deprecation warnings on Julia v0.6. So even though it works correctly it's kind of a nuisance -- is that a sufficient reason for not including this version of GP?

tkelman commented 7 years ago

You can definitely recommend using the very latest whenever possible, and that's what most people will be using, but if it doesn't error, then probably shouldn't rule it out completely (or force a Pkg error or inability to use this combination of versions at the same time).

tkelman commented 7 years ago

could you adjust the pending tag? see the attobot readme