search

JuliaGeometry / VoronoiDelaunay.jl

Fast and robust Voronoi & Delaunay tessellation creation with Julia
Other
123 stars 26 forks source link

[WIP/RFC] update to new iterator interface #44

Closed dkarrasch closed 5 years ago

dkarrasch commented 5 years ago

Fixes #43.

I'm not sure whether the iterator stuff was called at all, but I thought just in case I'll give it a try to adopt to the new iterator interface. At least, it should make the warnings go away.

dkarrasch commented 5 years ago

Hm, I'm finding the Coverage script calls cryptic, and can't seem to find an example (package) that works. Any hint would be highly appreciated.

dkarrasch commented 5 years ago

Seems like it was worth it. The iterator interface is used in

for t in tess
    # do something
end

which seems to be broken (and untested) on master. I have added a test now, which takes a random point, a Delaunay tesselation, and counts the number of triangles that the point is contained in. Generically, this should give one (unless the point falls exactly on one of the edges). I'll wait for a couple of days and merge, if there are no objections.

EDIT: Admittedly, I haven't done any benchmarking and/or optimization, but just rephrased the old start-next-done interface to the iterate-interface straightforwardly.